Improve scoping checks for objects, round 2#7749
Open
labkey-jeckels wants to merge 4 commits into
Open
Conversation
labkey-jeckels
commented
Jun 12, 2026
| // server-wide by LabKey SQL IN-clauses, filters, and OLAP member resolution. Mutating one therefore affects every | ||
| // folder, so require admin rather than letting any container Reader create/overwrite a global named set. | ||
| @RequiresPermission(AdminPermission.class) | ||
| public static class SaveNamedSetAction extends MutatingApiAction<NamedSetForm> |
Contributor
Author
There was a problem hiding this comment.
@labkey-matthewb can you review this and the DeleteNamedSetAction change?
labkey-adam
approved these changes
Jun 15, 2026
labkey-adam
left a comment
labkey-adam
left a comment
Contributor
There was a problem hiding this comment.
A couple things to consider, but no further review needed
| return Set.of( | ||
| AnnouncementManager.TestCase.class | ||
| AnnouncementManager.TestCase.class, | ||
| ToursController.ContainerScopingTestCase.class |
| { | ||
| for (int id : form.getRuns()) | ||
| { | ||
| ExpRun run = ExperimentService.get().getExpRun(id); |
Contributor
There was a problem hiding this comment.
Looks like Karl just added getExpRun(int, Container). Maybe useful here. Forcing the container to match current seems like a stronger check.
| for (int id : form.getRuns()) | ||
| { | ||
| ExpRun run = ExperimentService.get().getExpRun(id); | ||
| if (run == null || !run.getContainer().hasPermission(getUser(), QCAnalystPermission.class)) |
Contributor
There was a problem hiding this comment.
Should action permission check to QCAnalystPermission as well? Seems inconsistent.
| private MockHttpServletResponse postJson(ActionURL url, User user, JSONObject body) throws Exception | ||
| { | ||
| return ViewServlet.POST(url, user, Map.of("Content-Type", "application/json"), body.toString()); | ||
| } |
Contributor
There was a problem hiding this comment.
Move this to ViewServlet? I think I saw a couple uses in your tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We can improve our parameter validation
Changes